Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firewall_resource: support threat_intel_mode #7437

Merged
merged 2 commits into from Jun 23, 2020

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jun 23, 2020

Add threat_intel_mode to azurerm_firewall

Test Result

💤 via 🦉 v1.14.4 make testacc TEST=./azurerm/internal/services/compute/tests TESTARGS="-run='TestAccAzureRMMarketplaceAgreement'"                         
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/compute/tests -v -run='TestAccAzureRMMarketplaceAgreement' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMMarketplaceAgreement
=== RUN   TestAccAzureRMMarketplaceAgreement/basic
=== RUN   TestAccAzureRMMarketplaceAgreement/basic/basic
=== RUN   TestAccAzureRMMarketplaceAgreement/basic/requiresImport
=== RUN   TestAccAzureRMMarketplaceAgreement/basic/agreementCanceled
--- PASS: TestAccAzureRMMarketplaceAgreement (380.55s)
    --- PASS: TestAccAzureRMMarketplaceAgreement/basic (380.55s)
        --- PASS: TestAccAzureRMMarketplaceAgreement/basic/basic (144.67s)
        --- PASS: TestAccAzureRMMarketplaceAgreement/basic/requiresImport (149.40s)
        --- PASS: TestAccAzureRMMarketplaceAgreement/basic/agreementCanceled (86.48s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/compute/tests       380.564s

(fix #7336 )

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.16.0 milestone Jun 23, 2020
@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-06-23 at 18 33 12

@tombuildsstuff tombuildsstuff merged commit 6ca8e56 into hashicorp:master Jun 23, 2020
tombuildsstuff added a commit that referenced this pull request Jun 23, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
@ghost
Copy link

ghost commented Jul 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for threatIntelligenceMode property on azurerm_firewall
2 participants