Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_function_app app_settings refresh plan is not empty #7440

Merged
merged 1 commit into from Jun 23, 2020

Conversation

yupwei68
Copy link
Contributor

Fix: #6909

TestAccAzureRMFunctionApp_siteConfigMulti test fails for it has a comment to allow its failure

=== RUN TestAccAzureRMFunctionApp_appSettings
=== PAUSE TestAccAzureRMFunctionApp_appSettings
=== CONT TestAccAzureRMFunctionApp_appSettings
--- PASS: TestAccAzureRMFunctionApp_appSettings (373.24s)
=== RUN TestAccAzureRMFunctionApp_basic
=== PAUSE TestAccAzureRMFunctionApp_basic
=== CONT TestAccAzureRMFunctionApp_basic
--- PASS: TestAccAzureRMFunctionApp_basic (200.02s)
=== RUN TestAccAzureRMFunctionApp_deprecatedConnectionString
=== PAUSE TestAccAzureRMFunctionApp_deprecatedConnectionString
=== CONT TestAccAzureRMFunctionApp_deprecatedConnectionString
--- PASS: TestAccAzureRMFunctionApp_deprecatedConnectionString (182.47s)
=== RUN TestAccAzureRMFunctionApp_deprecatedConnectionStringMissingError
=== PAUSE TestAccAzureRMFunctionApp_deprecatedConnectionStringMissingError
=== CONT TestAccAzureRMFunctionApp_deprecatedConnectionStringMissingError
--- PASS: TestAccAzureRMFunctionApp_deprecatedConnectionStringMissingError (100.85s)
=== RUN TestAccAzureRMFunctionApp_deprecatedNeedBothSAAtrributesError
=== PAUSE TestAccAzureRMFunctionApp_deprecatedNeedBothSAAtrributesError
=== CONT TestAccAzureRMFunctionApp_deprecatedNeedBothSAAtrributesError
--- PASS: TestAccAzureRMFunctionApp_deprecatedNeedBothSAAtrributesError (105.36s)
=== RUN TestAccAzureRMFunctionApp_requiresImport
=== PAUSE TestAccAzureRMFunctionApp_requiresImport
=== CONT TestAccAzureRMFunctionApp_requiresImport
--- PASS: TestAccAzureRMFunctionApp_requiresImport (197.67s)
=== RUN TestAccAzureRMFunctionApp_tags
=== PAUSE TestAccAzureRMFunctionApp_tags
=== CONT TestAccAzureRMFunctionApp_tags
--- PASS: TestAccAzureRMFunctionApp_tags (184.50s)
=== RUN TestAccAzureRMFunctionApp_tagsUpdate
=== PAUSE TestAccAzureRMFunctionApp_tagsUpdate
=== CONT TestAccAzureRMFunctionApp_tagsUpdate
--- PASS: TestAccAzureRMFunctionApp_tagsUpdate (236.73s)
=== RUN TestAccAzureRMFunctionApp_siteConfig
=== PAUSE TestAccAzureRMFunctionApp_siteConfig
=== CONT TestAccAzureRMFunctionApp_siteConfig
--- PASS: TestAccAzureRMFunctionApp_siteConfig (203.37s)
=== RUN TestAccAzureRMFunctionApp_linuxFxVersion
=== PAUSE TestAccAzureRMFunctionApp_linuxFxVersion
=== CONT TestAccAzureRMFunctionApp_linuxFxVersion
--- PASS: TestAccAzureRMFunctionApp_linuxFxVersion (210.94s)
=== RUN TestAccAzureRMFunctionApp_connectionStrings
=== PAUSE TestAccAzureRMFunctionApp_connectionStrings
=== CONT TestAccAzureRMFunctionApp_connectionStrings
--- PASS: TestAccAzureRMFunctionApp_connectionStrings (235.29s)
=== RUN TestAccAzureRMFunctionApp_updateVersion
=== PAUSE TestAccAzureRMFunctionApp_updateVersion
=== CONT TestAccAzureRMFunctionApp_updateVersion
--- PASS: TestAccAzureRMFunctionApp_updateVersion (253.16s)
=== RUN TestAccAzureRMFunctionApp_3264bit
=== PAUSE TestAccAzureRMFunctionApp_3264bit
=== CONT TestAccAzureRMFunctionApp_3264bit
--- PASS: TestAccAzureRMFunctionApp_3264bit (245.15s)
=== RUN TestAccAzureRMFunctionApp_httpsOnly
=== PAUSE TestAccAzureRMFunctionApp_httpsOnly
=== CONT TestAccAzureRMFunctionApp_httpsOnly
--- PASS: TestAccAzureRMFunctionApp_httpsOnly (233.81s)
=== RUN TestAccAzureRMFunctionApp_dailyMemoryTimeQuota
=== PAUSE TestAccAzureRMFunctionApp_dailyMemoryTimeQuota
=== CONT TestAccAzureRMFunctionApp_dailyMemoryTimeQuota
--- PASS: TestAccAzureRMFunctionApp_dailyMemoryTimeQuota (461.59s)
=== RUN TestAccAzureRMFunctionApp_consumptionPlan
=== PAUSE TestAccAzureRMFunctionApp_consumptionPlan
=== CONT TestAccAzureRMFunctionApp_consumptionPlan
--- PASS: TestAccAzureRMFunctionApp_consumptionPlan (267.14s)
=== RUN TestAccAzureRMFunctionApp_consumptionPlanUppercaseName
=== PAUSE TestAccAzureRMFunctionApp_consumptionPlanUppercaseName
=== CONT TestAccAzureRMFunctionApp_consumptionPlanUppercaseName
--- PASS: TestAccAzureRMFunctionApp_consumptionPlanUppercaseName (231.85s)
=== RUN TestAccAzureRMFunctionApp_createIdentity
=== PAUSE TestAccAzureRMFunctionApp_createIdentity
=== CONT TestAccAzureRMFunctionApp_createIdentity
--- PASS: TestAccAzureRMFunctionApp_createIdentity (298.92s)
=== RUN TestAccAzureRMFunctionApp_updateIdentity
=== PAUSE TestAccAzureRMFunctionApp_updateIdentity
=== CONT TestAccAzureRMFunctionApp_updateIdentity
--- PASS: TestAccAzureRMFunctionApp_updateIdentity (320.03s)
=== RUN TestAccAzureRMFunctionApp_userAssignedIdentity
=== PAUSE TestAccAzureRMFunctionApp_userAssignedIdentity
=== CONT TestAccAzureRMFunctionApp_userAssignedIdentity
--- PASS: TestAccAzureRMFunctionApp_userAssignedIdentity (354.79s)
=== RUN TestAccAzureRMFunctionApp_loggingDisabled
=== PAUSE TestAccAzureRMFunctionApp_loggingDisabled
=== CONT TestAccAzureRMFunctionApp_loggingDisabled
--- PASS: TestAccAzureRMFunctionApp_loggingDisabled (185.11s)
=== RUN TestAccAzureRMFunctionApp_updateLogging
=== PAUSE TestAccAzureRMFunctionApp_updateLogging
=== CONT TestAccAzureRMFunctionApp_updateLogging
--- PASS: TestAccAzureRMFunctionApp_updateLogging (369.63s)
=== RUN TestAccAzureRMFunctionApp_authSettings
=== PAUSE TestAccAzureRMFunctionApp_authSettings
=== CONT TestAccAzureRMFunctionApp_authSettings
--- PASS: TestAccAzureRMFunctionApp_authSettings (185.78s)
=== RUN TestAccAzureRMFunctionApp_corsSettings
=== PAUSE TestAccAzureRMFunctionApp_corsSettings
=== CONT TestAccAzureRMFunctionApp_corsSettings
--- PASS: TestAccAzureRMFunctionApp_corsSettings (195.02s)
=== RUN TestAccAzureRMFunctionApp_enableHttp2
=== PAUSE TestAccAzureRMFunctionApp_enableHttp2
=== CONT TestAccAzureRMFunctionApp_enableHttp2
--- PASS: TestAccAzureRMFunctionApp_enableHttp2 (196.20s)
=== RUN TestAccAzureRMFunctionApp_minTlsVersion
=== PAUSE TestAccAzureRMFunctionApp_minTlsVersion
=== CONT TestAccAzureRMFunctionApp_minTlsVersion
--- PASS: TestAccAzureRMFunctionApp_minTlsVersion (199.97s)
=== RUN TestAccAzureRMFunctionApp_ftpsState
=== PAUSE TestAccAzureRMFunctionApp_ftpsState
=== CONT TestAccAzureRMFunctionApp_ftpsState
--- PASS: TestAccAzureRMFunctionApp_ftpsState (245.58s)
=== RUN TestAccAzureRMFunctionApp_preWarmedInstanceCount
=== PAUSE TestAccAzureRMFunctionApp_preWarmedInstanceCount
=== CONT TestAccAzureRMFunctionApp_preWarmedInstanceCount
--- PASS: TestAccAzureRMFunctionApp_preWarmedInstanceCount (259.39s)
=== RUN TestAccAzureRMFunctionApp_oneIpRestriction
=== PAUSE TestAccAzureRMFunctionApp_oneIpRestriction
=== CONT TestAccAzureRMFunctionApp_oneIpRestriction
--- PASS: TestAccAzureRMFunctionApp_oneIpRestriction (245.58s)
=== RUN TestAccAzureRMFunctionApp_oneVNetSubnetIpRestriction
=== PAUSE TestAccAzureRMFunctionApp_oneVNetSubnetIpRestriction
=== CONT TestAccAzureRMFunctionApp_oneVNetSubnetIpRestriction
--- PASS: TestAccAzureRMFunctionApp_oneVNetSubnetIpRestriction (214.37s)
=== RUN TestAccAzureRMFunctionApp_ipRestrictionRemoved
=== PAUSE TestAccAzureRMFunctionApp_ipRestrictionRemoved
=== CONT TestAccAzureRMFunctionApp_ipRestrictionRemoved
--- PASS: TestAccAzureRMFunctionApp_ipRestrictionRemoved (332.78s)
=== RUN TestAccAzureRMFunctionApp_manyIpRestrictions
=== PAUSE TestAccAzureRMFunctionApp_manyIpRestrictions
=== CONT TestAccAzureRMFunctionApp_manyIpRestrictions
--- PASS: TestAccAzureRMFunctionApp_manyIpRestrictions (273.04s)
=== RUN TestAccAzureRMFunctionApp_updateStorageAccountKey
=== PAUSE TestAccAzureRMFunctionApp_updateStorageAccountKey
=== CONT TestAccAzureRMFunctionApp_updateStorageAccountKey
--- PASS: TestAccAzureRMFunctionApp_updateStorageAccountKey (318.79s)

@ghost ghost added the size/M label Jun 23, 2020
@jackofallops jackofallops added the service/functions Function Apps label Jun 23, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - This LGTM 👍

@jackofallops jackofallops added this to the v2.16.0 milestone Jun 23, 2020
@jackofallops
Copy link
Member

Tests pass:
image
2 failures unrelated to changes

@jackofallops jackofallops merged commit f5da29e into hashicorp:master Jun 23, 2020
jackofallops added a commit that referenced this pull request Jun 23, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
@yupwei68 yupwei68 deleted the wyp-function-app branch July 10, 2020 02:02
@ghost
Copy link

ghost commented Jul 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Settings from Function App asking to be modified every time I run terraform apply
2 participants