azurerm_mssql_database - support GP_S_Gen5 SKUs up to GP_S_Gen5_40
#7453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
katbyte
changed the title
GP_S_Gen5 SKUs up to GP_S_Gen5_40
katbyte
added a commit
that referenced
this pull request
Jun 23, 2020
|
This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.16.0"
}
# ... other configuration ... |
jrauschenbusch
pushed a commit
to jrauschenbusch/terraform-provider-azurerm
that referenced
this pull request
Jun 29, 2020
hashicorp#7453) SKUs for GP_S_Gen5 databases go up to GP_S_Gen5_40 (docs), but the current validator function only allows up to GP_S_Gen5_16. This PR updates the validator to allow all documented serverless SKUs. This is my first contribution to this, or any Terraform Provider, so please let me know what validation or testing steps I need to do on my end to button up this pull request.
jrauschenbusch
pushed a commit
to jrauschenbusch/terraform-provider-azurerm
that referenced
this pull request
Jun 29, 2020
jrauschenbusch
pushed a commit
to jrauschenbusch/terraform-provider-azurerm
that referenced
this pull request
Jun 29, 2020
hashicorp#7453) SKUs for GP_S_Gen5 databases go up to GP_S_Gen5_40 (docs), but the current validator function only allows up to GP_S_Gen5_16. This PR updates the validator to allow all documented serverless SKUs. This is my first contribution to this, or any Terraform Provider, so please let me know what validation or testing steps I need to do on my end to button up this pull request.
jrauschenbusch
pushed a commit
to jrauschenbusch/terraform-provider-azurerm
that referenced
this pull request
Jun 29, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SKUs for
GP_S_Gen5databases go up toGP_S_Gen5_40(docs), but the current validator function only allows up toGP_S_Gen5_16. This PR updates the validator to allow all documented serverless SKUs.This is my first contribution to this, or any Terraform Provider, so please let me know what validation or testing steps I need to do on my end to button up this pull request.