Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_database - support min_capacity up to 5 #7457

Merged
merged 1 commit into from Jun 24, 2020

Conversation

davidtom
Copy link
Contributor

Minimum capacities for GP_S_Gen5 serverless databases go from 0.5 to 5 (docs), but the current validator function only allows min_capacity up to 2. This PR updates the validator to allow all documented minimum capacities for serverless databases.

@ghost ghost added the size/XS label Jun 24, 2020
@katbyte katbyte added bug service/mssql Microsoft SQL Server labels Jun 24, 2020
@katbyte katbyte added this to the v2.16.0 milestone Jun 24, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidtom, LGTM 👍

@katbyte katbyte merged commit e4f3b53 into hashicorp:master Jun 24, 2020
katbyte added a commit that referenced this pull request Jun 24, 2020
@davidtom davidtom deleted the update-mssql-min-capacities branch June 24, 2020 04:34
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
Minimum capacities for GP_S_Gen5 serverless databases go from 0.5 to 5 (docs), but the current validator function only allows min_capacity up to 2. This PR updates the validator to allow all documented minimum capacities for serverless databases.
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
Minimum capacities for GP_S_Gen5 serverless databases go from 0.5 to 5 (docs), but the current validator function only allows min_capacity up to 2. This PR updates the validator to allow all documented minimum capacities for serverless databases.
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
@ghost
Copy link

ghost commented Jul 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants