Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update path validation for azure_rm_api_management_api #7478

Merged
merged 3 commits into from Jun 25, 2020

Conversation

xinyi-joffre
Copy link
Contributor

@xinyi-joffre xinyi-joffre commented Jun 24, 2020

This fixes #7477 bug for path validation being too strict.

The Azure RM API Management API can support paths that begin with a period, such as ".well-known".

This updates the validation logic for this field so that Terraform will allow this type of path.

Adding support for paths that start with the character '.'

This is important for path implementations such as ".well-known" in universal links
…validation

Update path validation for api management api
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @xinyi-joffre

@tombuildsstuff tombuildsstuff merged commit 127eb47 into hashicorp:master Jun 25, 2020
tombuildsstuff added a commit that referenced this pull request Jun 25, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
@ghost
Copy link

ghost commented Jul 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_api_management_api path validation too strict
2 participants