Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testcontainers-go] Named volumes don't get cleaned up by Ryuk #103

Closed
mdelapenya opened this issue Feb 1, 2024 · 2 comments
Closed

[testcontainers-go] Named volumes don't get cleaned up by Ryuk #103

mdelapenya opened this issue Feb 1, 2024 · 2 comments

Comments

@mdelapenya
Copy link
Contributor

          > @mdelapenya in case you missed it, please have a look at my additional demo above ([#2163 (comment)](https://github.com/testcontainers/testcontainers-go/issues/2163#issuecomment-1919561727)), which shows how named volumes don't get cleaned up by Ryuk.

I think we should open a bug in https://github.com/testcontainers/moby-ryuk

Originally posted by @mdelapenya in testcontainers/testcontainers-go#2163 (comment)

@mdelapenya mdelapenya changed the title Named volumes don't get cleaned up by Ryuk. [testcontainers-go] Named volumes don't get cleaned up by Ryuk Feb 1, 2024
@mdelapenya
Copy link
Contributor Author

Mmm wrong repo. I think the issue comes from testcontainers-go, closing

@srabraham
Copy link

Yeah, there was some relevant activity in moby-ryuk almost a year ago, see
docker/cli#4028
docker/cli#4028
#79

but maybe some additional work was needed in the testcontainers implementation repos too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants