Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add InfluxDb module #975

Merged
merged 9 commits into from
Aug 17, 2023

Conversation

MelomanG
Copy link
Contributor

What does this PR do?

This PR adds support for starting [InfluxDb] containers.

Why is it important?

This is required to write tests that target a InfluxDb database.

Related issues

How to test this PR

cd tests/Testcontainers.InfluxDb.Tests
dotnet test

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 371d8fd
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/64de5607cb094600085bbeda
😎 Deploy Preview https://deploy-preview-975--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. The majority of it looks good. I've removed the BOMs and applied some common code styles. I've also included two minor suggestions. This is a great first Testcontainers for .NET contribution 👍. Thanks again.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks!

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Aug 17, 2023
@HofmeisterAn HofmeisterAn merged commit 7808ac4 into testcontainers:develop Aug 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add InfluxDB module
2 participants