chore: Update BouncyCastle.Cryptography to 2.2.1 (previous Portable.BouncyCastle) #985
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
changed the title
HofmeisterAn
added
the
chore
There was a problem hiding this comment.
Thank you for bringing this to my attention. I was unaware of the recent changes in the .NET Bouncy Castle project. It's great that we can revert to the main distribution, although Claire's version was running smoothly.
This builds but the tests have some failures I'm not able to diagnose; also the test process stalled on the last step (see gist) for more than 15 minutes before I killed it.
I don't believe these issues are related to your changes. All the tests run smoothly on my Windows machine with Docker Desktop. However, running the tests simultaneously puts a lot of load on the system. Depending on the available resources, there might be cases where the containers fail to start correctly. If you're able to reproduce the issues, it would be great if you could provide additional information. This would help in determining whether these issues require a fix.
|
Yeah, I'm fairly sure it has something to do with my setup, although I'm also on Windows with Docker Desktop. I'll see if I can discover more about what's going on. |
Dependency update.
What does this PR do?
Moving back to the main distro of BouncyCastle.Crypto now that it supports netstandard etc.
https://www.nuget.org/packages/BouncyCastle.Cryptography
Why is it important?
Portable.BouncyCastle hasn't been updated in almost 2 years, and I assume Claire didn't intend to own it forever.
Related issues
n/a (that I know of)
How to test this PR
This builds but the tests have some failures I'm not able to diagnose; also the test process stalled on the last step (see gist) for more than 15 minutes before I killed it.
https://gist.github.com/jcmrva/c83912eb5834b4c0d67f07671b0771d0