diff --git a/docker_test.go b/docker_test.go index 4e2331904d..5d3561e2d4 100644 --- a/docker_test.go +++ b/docker_test.go @@ -6,6 +6,7 @@ import ( "errors" "fmt" "log" + "path" // Import mysql into the scope of this package (required) "io" @@ -26,7 +27,6 @@ import ( "github.com/go-redis/redis/v8" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" - "gotest.tools/v3/fs" "github.com/docker/docker/errdefs" @@ -1481,8 +1481,8 @@ func TestReadTCPropsFile(t *testing.T) { }) t.Run("HOME does not contain TC props file", func(t *testing.T) { - tmpDir := fs.NewDir(t, os.TempDir()) - t.Setenv("HOME", tmpDir.Path()) + tmpDir := t.TempDir() + t.Setenv("HOME", tmpDir) config := configureTC() @@ -1490,8 +1490,8 @@ func TestReadTCPropsFile(t *testing.T) { }) t.Run("HOME does not contain TC props file - TESTCONTAINERS_ env is set", func(t *testing.T) { - tmpDir := fs.NewDir(t, os.TempDir()) - t.Setenv("HOME", tmpDir.Path()) + tmpDir := t.TempDir() + t.Setenv("HOME", tmpDir) t.Setenv("TESTCONTAINERS_RYUK_CONTAINER_PRIVILEGED", "true") config := configureTC() @@ -1697,12 +1697,12 @@ func TestReadTCPropsFile(t *testing.T) { } for i, tt := range tests { t.Run(fmt.Sprintf("[%d]", i), func(t *testing.T) { - tmpDir := fs.NewDir(t, os.TempDir()) - t.Setenv("HOME", tmpDir.Path()) + tmpDir := t.TempDir() + t.Setenv("HOME", tmpDir) for k, v := range tt.env { t.Setenv(k, v) } - if err := os.WriteFile(tmpDir.Join(".testcontainers.properties"), []byte(tt.content), 0o600); err != nil { + if err := os.WriteFile(path.Join(tmpDir, ".testcontainers.properties"), []byte(tt.content), 0o600); err != nil { t.Errorf("Failed to create the file: %v", err) return } diff --git a/go.mod b/go.mod index 02b321bb7a..1b47dedeb5 100644 --- a/go.mod +++ b/go.mod @@ -22,7 +22,6 @@ require ( golang.org/x/sys v0.1.0 gopkg.in/yaml.v3 v3.0.1 gotest.tools/gotestsum v1.8.2 - gotest.tools/v3 v3.4.0 ) replace ( diff --git a/go.sum b/go.sum index 337d999c2d..60dba0c740 100644 --- a/go.sum +++ b/go.sum @@ -1068,7 +1068,6 @@ gotest.tools/gotestsum v1.8.2/go.mod h1:6JHCiN6TEjA7Kaz23q1bH0e2Dc3YJjDUZ0DmctFZ gotest.tools/v3 v3.0.2/go.mod h1:3SzNCllyD9/Y+b5r9JIKQ474KzkZyqLqEfYqMsX94Bk= gotest.tools/v3 v3.3.0/go.mod h1:Mcr9QNxkg0uMvy/YElmo4SpXgJKWgQvYrT7Kw5RzJ1A= gotest.tools/v3 v3.4.0 h1:ZazjZUfuVeZGLAmlKKuyv3IKP5orXcwtOwDQH6YVr6o= -gotest.tools/v3 v3.4.0/go.mod h1:CtbdzLSsqVhDgMtKsx03ird5YTGB3ar27v0u/yKBW5g= honnef.co/go/tools v0.0.0-20180728063816-88497007e858/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4= honnef.co/go/tools v0.0.0-20190102054323-c2f93a96b099/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4= honnef.co/go/tools v0.0.0-20190106161140-3f1c8253044a/go.mod h1:rf3lG4BRIbNafJWhAfAdb/ePZxsR/4RtNHQocxwk9r4= diff --git a/logconsumer_test.go b/logconsumer_test.go index 32233e0633..cfddbdd847 100644 --- a/logconsumer_test.go +++ b/logconsumer_test.go @@ -10,8 +10,8 @@ import ( "testing" "time" + "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" - "gotest.tools/v3/assert" "github.com/docker/docker/client" @@ -106,7 +106,7 @@ func Test_LogConsumerGetsCalled(t *testing.T) { // get rid of the server "ready" log g.Msgs = g.Msgs[1:] - assert.DeepEqual(t, []string{"echo hello\n", "echo there\n"}, g.Msgs) + assert.Equal(t, []string{"echo hello\n", "echo there\n"}, g.Msgs) terminateContainerOnEnd(t, ctx, c) } @@ -181,7 +181,7 @@ func Test_ShouldRecognizeLogTypes(t *testing.T) { <-g.Ack _ = c.StopLogProducer() - assert.DeepEqual(t, map[string]string{ + assert.Equal(t, map[string]string{ StdoutLog: "echo this-is-stdout\n", StderrLog: "echo this-is-stderr\n", }, g.LogTypes) diff --git a/wait/http_test.go b/wait/http_test.go index f176bd1b7e..b74c3dc7d2 100644 --- a/wait/http_test.go +++ b/wait/http_test.go @@ -11,6 +11,7 @@ import ( "net" "net/http" "os" + "path" "testing" "time" @@ -51,7 +52,7 @@ func TestHTTPStrategyWaitUntilReady(t *testing.T) { return } - capath := workdir + "/testdata/root.pem" + capath := path.Join(workdir, "testdata", "root.pem") cafile, err := os.ReadFile(capath) if err != nil { t.Errorf("can't load ca file: %v", err) @@ -68,7 +69,7 @@ func TestHTTPStrategyWaitUntilReady(t *testing.T) { var i int dockerReq := testcontainers.ContainerRequest{ FromDockerfile: testcontainers.FromDockerfile{ - Context: workdir + "/testdata", + Context: path.Join(workdir, "/testdata"), }, ExposedPorts: []string{"6443/tcp"}, WaitingFor: wait.NewHTTPStrategy("/ping").WithTLS(true, tlsconfig).