feat: Add ability to disable internal checks for wait.HostPortStrategy
#1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mdelapenya
reviewed
Apr 6, 2023
mdelapenya
reviewed
Apr 18, 2023
|
Hey @RiverPhillips I'm going to apply the suggestion and merge this PR, as we are planning a release and I'd like to include this feature. Thanks for taking the time to elaborate the issue alongside this PR 🙇 |
|
Kudos, SonarCloud Quality Gate passed!
|
weeco
pushed a commit
to weeco/testcontainers-go
that referenced
this pull request
Apr 24, 2023
…gy` (testcontainers#1039) * chore: refactor internal and external checks to be separate methods * Add flag to disable internal checks for HostPort * log when shell is not installed * chore: apply line break in the log --------- Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the ability to disable the internal check for the
wait.HostPortStrategyWhy is it important?
When using images without a shell the
wait.HostPortStrategyfails due to the internal checks. This makes it possible to disable these internal checksRelated issues
HostPortStrategy#1038