Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run pipelines in order #1130

Merged
merged 6 commits into from
May 3, 2023

Conversation

mdelapenya
Copy link
Collaborator

@mdelapenya mdelapenya commented May 2, 2023

What does this PR do?

This PR sets the execution order of the existing workflows as follows:

  1. Linting: golangci-lint.yml
  2. Main pipeline, will run in parallel:
    • Regular pipeline: ci.yml
    • Reaper Off pipeline: ci-reaper-off.yml
  3. Modules generator pipeline: ci-modulegen.yml
  4. Modules pipeline, will run in parallel:
    • All modules' pipelines
    • All examples' pipelines

MermaidJS diagram created with https://mermaid.live.

flowchart TD
    A[golangci-lint] -->|Reaper-on| B(Main Pipeline)
    A[golangci-lint] -->|Reaper-off| B(Main Pipeline)
    B -->|Module Generator| C[Module generator]
    C -->|Modules| D[All modules]
    C -->|Examples| E[All examples]

Why is it important?

Do not launch all pipelines at the same time, and create different stages:

  • if the lint does not pass, do not even trigger the main pipeline
  • if the main pipeline does not pass, do not even trigger the modules/examples pipelines

@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label May 2, 2023
@mdelapenya mdelapenya self-assigned this May 2, 2023
@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit cb3eeaa
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64528c20b055240008985175
😎 Deploy Preview https://deploy-preview-1130--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

* main:
  chore(deps): bump github.com/apache/pulsar-client-go in /modules/pulsar (testcontainers#1105)
  chore(deps): bump github.com/docker/{cli|docker} from 23.0.3+incompatible to 23.0.5+incompatible in /modules (testcontainers#1132)
  chore(deps): bump google.golang.org/api to 0.120.0 in /examples (testcontainers#1131)
  chore(deps): bump github.com/cenkalti/backoff/v4 in /modules/couchbase (testcontainers#1099)
  chore(deps): bump github.com/go-sql-driver/mysql in /modules/mysql (testcontainers#1122)
  chore(deps): bump github.com/lib/pq in /modules/postgres (testcontainers#1127)
  chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (testcontainers#1126)
  chore(deps): bump golang.org/x/text from 0.8.0 to 0.9.0 in /modulegen (testcontainers#1095)
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya mdelapenya marked this pull request as ready for review May 3, 2023 22:06
@mdelapenya mdelapenya requested a review from a team as a code owner May 3, 2023 22:06
@mdelapenya mdelapenya merged commit 0df60de into testcontainers:main May 3, 2023
60 checks passed
@mdelapenya mdelapenya deleted the gh-workflow-order branch May 4, 2023 05:41
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request May 7, 2023
mdelapenya added a commit that referenced this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant