chore: Removes the refercence about docker 22.06 from the docker-compose docs #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose docs and updates the replace directive for the compose module.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
mdelapenya
approved these changes
May 24, 2023
mdelapenya
added a commit
that referenced
this pull request
May 25, 2023
…containerd-1.7.1 * main: chore(deps): bump golang.org/x/sys from 0.7.0 to 0.8.0 (#1202) chore(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3 (#1232) chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (#1226) chore: Removes the refercence about docker 22.06 from the docker-compose docs and updates the replace directive for the compose module. (#1243) chore(deps): bump go.mongodb.org/mongo-driver in /examples/mongodb (#1233) chore(deps): bump google.golang.org/api from 0.123.0 to 0.124.0 in /examples (#1244) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (#1241) chore(deps): bump github.com/aws/aws-sdk-go in /modules/localstack (#1242) added NATS JetStream example (#1190) chore(deps): bump github.com/imdario/mergo from 0.3.12 to 0.3.15 (#1204) chore(deps): bump cloud.google.com/go/firestore in /examples/firestore (#1216) chore(deps): bump k8s.io/client-go from 0.22.5 to 0.27.2 in /modules/k3s (#1211) chore(deps): bump go.mongodb.org/mongo-driver in /examples/mongodb (#1092) chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (#1206) chore(deps): bump github.com/twmb/franz-go in /modules/redpanda (#1201) chore(deps): bump google.golang.org/api from 0.121.0 to 0.123.0 in /examples (#1229) chore(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3 (#1228) chore: use fixed version in k3s module (#1225)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
May 26, 2023
* main: (22 commits) docs: document the Go version (testcontainers#1246) chore(deps): bump github.com/aws/aws-sdk-go-v2/config (testcontainers#1222) chore(deps): bump golang.org/x/sys from 0.7.0 to 0.8.0 (testcontainers#1202) chore(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3 (testcontainers#1232) chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (testcontainers#1226) chore: Removes the refercence about docker 22.06 from the docker-compose docs and updates the replace directive for the compose module. (testcontainers#1243) chore(deps): bump go.mongodb.org/mongo-driver in /examples/mongodb (testcontainers#1233) chore(deps): bump google.golang.org/api from 0.123.0 to 0.124.0 in /examples (testcontainers#1244) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (testcontainers#1241) chore(deps): bump github.com/aws/aws-sdk-go in /modules/localstack (testcontainers#1242) added NATS JetStream example (testcontainers#1190) chore(deps): bump github.com/imdario/mergo from 0.3.12 to 0.3.15 (testcontainers#1204) chore(deps): bump cloud.google.com/go/firestore in /examples/firestore (testcontainers#1216) chore(deps): bump k8s.io/client-go from 0.22.5 to 0.27.2 in /modules/k3s (testcontainers#1211) chore(deps): bump go.mongodb.org/mongo-driver in /examples/mongodb (testcontainers#1092) chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (testcontainers#1206) chore(deps): bump github.com/twmb/franz-go in /modules/redpanda (testcontainers#1201) chore(deps): bump google.golang.org/api from 0.121.0 to 0.123.0 in /examples (testcontainers#1229) chore(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.3 (testcontainers#1228) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, updates the replace directive for the compose module.
What does this PR do?
As discussed in #1231 the docs are out of sync with the actual replace directive.
Note that it might be necessary merge this PR only after the next release of docker-compose as it reflects the replace on the current v2 branch.
Why is it important?
The docs should be updated so that new users don't get confused by the warning in the how to guide.