New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix passing env vars example #1252

Merged

mdelapenya merged 1 commit into testcontainers:main from borod108:doc/fix_env_var_example

Jun 1, 2023

Contributor

borod108 commented Jun 1, 2023

Doc fix, the current given example does not compile, suggested a fix.


          Fix passing env vars example

f5df534

The current example does not compile, suggested a fix.

borod108 requested a review from a team as a code owner

June 1, 2023 10:23

netlify bot commented Jun 1, 2023 •

edited

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	`f5df534`
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/6478719075731200087d609a
😎 Deploy Preview	https://deploy-preview-1252--testcontainers-go.netlify.app/features/build_from_dockerfile
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mdelapenya approved these changes

View reviewed changes

Collaborator

mdelapenya left a comment

Good catch! LGTM

I need to update the code snippets to directly use code that does exist in the current tests.

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

mdelapenya self-assigned this

mdelapenya added the documentation label

mdelapenya changed the title ~~Fix passing env vars example~~ docs: fix passing env vars example

mdelapenya merged commit bc15b11 into testcontainers:main

8 checks passed

Collaborator

mdelapenya commented Jun 1, 2023

Thank you for the fix! 🙇

The docs will automatically deployed to our site using Netlify, so it should be there in a couple of minutes

Contributor Author

borod108 commented Jun 1, 2023

@mdelapenya wow thank you for the quick merge, I am deeply impressed by your responsiveness :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment