fix: skip host network tests in Docker Desktop #1285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a public function to skip tests in the case Docker Desktop is used. We are also using this new function in 4 tests, that are setting Docker's host network via the
HostConfigModifier
. Therefore, they will be skipped when run on Docker Desktop.Why is it important?
This PR fixes the execution of the test suite in those environments where it's not possible to run all the tests. As an example, using the host network is not possible when running Docker Desktop (for Mac or for Windows).
With this change, it's possible now to run the entire test suite across all OSs