Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locations set to None in sitemap #1296

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

leocross
Copy link
Contributor

What does this do

Fix a bug with the documentation generating a sitemap with <loc>None</loc> seamingly caused by not having site_url set in the mkdocs config.

e.g.

<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
  <url>
    <loc>None</loc>
    <lastmod>2023-06-15</lastmod>
    <changefreq>daily</changefreq>
  </url>
  ...
</urlset>

Why is this important

Search engines and other tools use the sitemap, presenting correct information is important for discoverability of the documentation.

@leocross leocross requested a review from a team as a code owner June 20, 2023 17:35
@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit cb14391
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6491e36087d7dd00080dd97e
😎 Deploy Preview https://deploy-preview-1296--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya mdelapenya self-assigned this Jun 20, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Jun 20, 2023
@mdelapenya mdelapenya merged commit bb126ce into testcontainers:main Jun 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants