Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add a Windows pipeline for running the tests #1375

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

mdelapenya
Copy link
Collaborator

@mdelapenya mdelapenya commented Aug 1, 2023

  • chore(ci): add a GH pipeline to trigger the windows worker
  • chore(ci): remove windows worker from the regular pipeline

What does this PR do?

It adds two GH workflows: one for listening to GH comments as commands:

  • It will listen to the /windows-test command as a GH comment for maintainers, triggering the pipeline for windows, using the Azure self-hosted workers.
  • A second workflow with the real test execution on our self-hosted workers on Azure.

It also removes the windows build from the main pipeline, as it's not needed anymore.

Why is it important?

Test on Windows is key for many users, so we must be aware of potential bugs on that platform, which is widely used by our community.

Related issues

It will listen to the `/windows-test` command as a GH comment for maintainers,
triggering the pipeline for windows, using the Azure self-hosted workers.
@mdelapenya mdelapenya requested a review from a team as a code owner August 1, 2023 10:38
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 1, 2023
@mdelapenya mdelapenya self-assigned this Aug 1, 2023
@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 740882c
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64ca10bff721cd0008f87387
😎 Deploy Preview https://deploy-preview-1375--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya
Copy link
Collaborator Author

Merging, as it does not affect the existing pipelines

@mdelapenya mdelapenya merged commit c0797a0 into testcontainers:main Aug 2, 2023
59 checks passed
@mdelapenya mdelapenya deleted the windows-pipeline branch August 2, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: run tests on Windows on a certain schedule
2 participants