chore(deps): bump docker dependencies to v24.0.5+incompatible #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…mpatible It will avoid the deprecation of types.AuthConfig, causing a breaking change in the library
mdelapenya
changed the title
…7fc+incompatible" This reverts commit 5ac8e39.
All consumers building from a Dockerfile must check that they are not affected
mdelapenya
changed the title
Closed
|
Kudos, SonarCloud Quality Gate passed!
|
mdelapenya
commented
Aug 2, 2023
This was referenced Aug 2, 2023
Merged
|
Any ETA on a release that include the fix? |
Hi @davideme I'm planning it for the end of this week, so hopefully we can have it tomorrow 🤞 |
8 tasks
alexrodfe
added a commit
to konstellation-io/kai
that referenced
this pull request
Aug 16, 2023
…ersion <!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> - Stream and key value store naming now cleanup dots in version tags. - Bumped go testcontainers version ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> Naming in nats' resources cannot contain dots, so we are replacing dots introduced in version tags for underscores. _IMPORTANT_ Bug found regarding the usage of go testcontainers for go versions 1.20.6 and onwards, testcontainers v0.23.0 seems to tackle this problem, however it is important to keep on check for go 1.21 as versions will have to be matched again as explained in: testcontainers/testcontainers-go#1394 ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Other changes (ci configuration, documentation or any other kind of changes) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [X] I have created tests for my code changes, and the tests are passing. - [X] I have executed the pre-commit hooks locally. - [ ] My change requires a change to the documentation (create a new issue if the documentation has not been updated). - [ ] I have updated the documentation accordingly.
cuppett
added a commit
to cuppett/mysql-dba-operator
that referenced
this pull request
Sep 7, 2023
cuppett
added a commit
to cuppett/mysql-dba-operator
that referenced
this pull request
Sep 10, 2023
Resolves #33: Adds character set and collation validation & constraints to CRs * Adding basic fields for character set and collation * Allowing collation to be null * Populate AvailabeCharSets struct and add some tests for nonEmpty * Refactor adminConnection to ServerAdminConnection in controller tests * Bumps to fix testcontainers with newer golang See also: testcontainers/testcontainers-go#1394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It bumps the core library and all the modules to Docker v24.0.5+incompatible.
Besides that, we were forced to introduce a breaking change, as this PR updates the references to the deprecated Docker's
types.AuthConfig, using Docker'sregistry.AuthConfiginstead. The code that was affected was the one related to building containers from a Dockerfile. We will update the release notes in the upcoming release.As a consequence of the Docker bump in the compose module, we were forced to bump certain dependencies in the compose module that needs Go 1.20, therefore, we are temporarily retiring the GH workflow for running the compose module using Go 1.19. Once Go 1.21 is out, we will update that file to include the classic two-version window for compiling the project. A positive change here is that the
replacedirective when using the compose module has been simplified.Why is it important?
See #1359 and how the Go versions broke how the host headers are validated by Docker and us.
Related issues