New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify and do not run make on windows #1445

Merged

mdelapenya merged 1 commit into testcontainers:main from mdelapenya:do-not-use-make

Aug 7, 2023

Collaborator

mdelapenya commented Aug 7, 2023

What does this PR do?

Do not use make

Why is it important?

It's not installed on windows


          fix: simplify and do not run make on windows

f348f56

mdelapenya requested a review from a team as a code owner

August 7, 2023 10:54

mdelapenya added the dependencies label

mdelapenya self-assigned this

netlify bot commented Aug 7, 2023 •

edited

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	`f348f56`
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/64d0cd71916e590008b8b6b1
😎 Deploy Preview	https://deploy-preview-1445--testcontainers-go.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdelapenya merged commit 4089912 into testcontainers:main

13 of 14 checks passed

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

mdelapenya deleted the do-not-use-make branch

August 7, 2023 10:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment