Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for WASM Transforms to Redpanda Module #2170

Conversation

gene-redpanda
Copy link
Contributor

What does this PR do?

Adds a flag to the bootstrap file to enable Redpanda WASM transforms. Also disables the flag automatically if used with a version that does not support them.

Why is it important?

Necessary to support this feature for downstream testing.

Related issues

None

How to test this PR

Run the automated tests

Follow-ups

None

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 6495231
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65bd10a19870fb000807bc58
😎 Deploy Preview https://deploy-preview-2170--testcontainers-go.netlify.app/modules/redpanda
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gene-redpanda gene-redpanda changed the title add support for wasm transforms DRAFT: add support for wasm transforms Jan 26, 2024
@gene-redpanda gene-redpanda force-pushed the feature/add-redpanda-wasm-transform branch 2 times, most recently from e7f1642 to 2ce7ff7 Compare January 26, 2024 20:14
@gene-redpanda gene-redpanda changed the title DRAFT: add support for wasm transforms Add Support for WASM Transforms to Redpanda Module Jan 26, 2024
@gene-redpanda gene-redpanda marked this pull request as ready for review January 26, 2024 20:14
@gene-redpanda gene-redpanda requested a review from a team as a code owner January 26, 2024 20:14
@gene-redpanda gene-redpanda force-pushed the feature/add-redpanda-wasm-transform branch from 2ce7ff7 to eebfae7 Compare January 29, 2024 16:11
modules/redpanda/go.mod Outdated Show resolved Hide resolved
modules/k3s/go.mod Outdated Show resolved Hide resolved
modules/redpanda/redpanda_test.go Show resolved Hide resolved
@gene-redpanda gene-redpanda force-pushed the feature/add-redpanda-wasm-transform branch 6 times, most recently from 9e5e83d to f578af2 Compare January 30, 2024 04:03
modules/redpanda/go.mod Outdated Show resolved Hide resolved
@gene-redpanda gene-redpanda force-pushed the feature/add-redpanda-wasm-transform branch from f578af2 to 46fc04c Compare January 30, 2024 16:46
@gene-redpanda gene-redpanda force-pushed the feature/add-redpanda-wasm-transform branch from 46fc04c to 0ff36cd Compare January 30, 2024 16:46
gene-redpanda added a commit to redpanda-data/console that referenced this pull request Jan 31, 2024
Adds integration tests. Depends on testcontainers/testcontainers-go#2170 which I've added using a replace directive to enable testing/reviewing. I will remove it as soon as I can get the upstream PR merged.
@mdelapenya mdelapenya self-assigned this Jan 31, 2024
@mdelapenya mdelapenya added the feature New functionality or new behaviors on the existing one label Jan 31, 2024
gene-redpanda added a commit to redpanda-data/console that referenced this pull request Feb 1, 2024
Adds integration tests. Depends on testcontainers/testcontainers-go#2170 which I've added using a replace directive to enable testing/reviewing. I will remove it as soon as I can get the upstream PR merged.
gene-redpanda added a commit to redpanda-data/console that referenced this pull request Feb 1, 2024
Adds integration tests. Depends on testcontainers/testcontainers-go#2170 which I've added using a replace directive to enable testing/reviewing. I will remove it as soon as I can get the upstream PR merged.
* main:
  feat(modules.clickhouse): Add zookeeper for clickhouse clusterization (testcontainers#1995)
  redpanda: allow using SASL and TLS together (testcontainers#2140)
  chore: do not panic in testable examples (testcontainers#2193)
  fix: all mounts should contain the testcontainers labels (testcontainers#2191)
  [redpanda] sasl test for wrong mechanism (testcontainers#2048)
  fix: deprecate BindMounts correctly (testcontainers#2190)
@mdelapenya
Copy link
Collaborator

@gene-redpanda I think this PR is ready to be merged! I added a commit on top to fix the lint to remove that load from you. Hopefully is not an issue, as I did it with the sole goal of making progress and merge this great contribution to the project.

@gene-redpanda
Copy link
Contributor Author

@gene-redpanda I think this PR is ready to be merged! I added a commit on top to fix the lint to remove that load from you. Hopefully is not an issue, as I did it with the sole goal of making progress and merge this great contribution to the project.

Thanks that's great! I don't have the ability to merge 😅

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit 5e6736f into testcontainers:main Feb 4, 2024
80 checks passed
gene-redpanda added a commit to redpanda-data/console that referenced this pull request Feb 5, 2024
Adds integration tests. Depends on testcontainers/testcontainers-go#2170 which I've added using a replace directive to enable testing/reviewing. I will remove it as soon as I can get the upstream PR merged.
gene-redpanda added a commit to redpanda-data/console that referenced this pull request Feb 7, 2024
Adds integration tests. Depends on testcontainers/testcontainers-go#2170 which I've added using a replace directive to enable testing/reviewing. I will remove it as soon as I can get the upstream PR merged.
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Feb 14, 2024
* main: (33 commits)
  feat (postgres): support for creating and restoring Snapshots (testcontainers#2199)
  fix: apply volume options only to volumes (testcontainers#2201)
  redpanda/test: add admin client call (testcontainers#2200)
  chore(deps): bump cloud.google.com/go/spanner from 1.55.0 to 1.56.0 in /modules/gcloud, cloud.google.com/go/pubsub from 1.35.0 to 1.36.1 in /modules/gcloud, cloud.google.com/go/bigquery from 1.57.1 to 1.58.0 in /modules/gcloud (testcontainers#2197)
  chore(deps): bump github.com/docker/docker from 25.0.1+incompatible to 25.0.2+incompatible (testcontainers#2196)
  fix: go doc reference broken image (testcontainers#2195)
  Add Support for WASM Transforms to Redpanda Module (testcontainers#2170)
  feat(modules.clickhouse): Add zookeeper for clickhouse clusterization (testcontainers#1995)
  redpanda: allow using SASL and TLS together (testcontainers#2140)
  chore: do not panic in testable examples (testcontainers#2193)
  fix: all mounts should contain the testcontainers labels (testcontainers#2191)
  [redpanda] sasl test for wrong mechanism (testcontainers#2048)
  fix: deprecate BindMounts correctly (testcontainers#2190)
  chore(docker_mounts): stop doing misleading logging (testcontainers#2178)
  fix: Add HTTPStrategy WithForcedIPv4LocalHost To Fix Docker Port Map (testcontainers#1775)
  chore(deps): bump github.com/docker/compose/v2 in /modules/compose (testcontainers#2162)
  feat(modules.cockroachdb) Adds cockroachdb module (testcontainers#2131)
  chore(deps): bump golang.org/x/crypto in /modules/minio (testcontainers#2161)
  chore(deps): bump golang.org/x/crypto in /modules/openldap (testcontainers#2165)
  chore(deps): bump github.com/google/uuid from 1.5.0 to 1.6.0 (testcontainers#2169)
  ...
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Feb 14, 2024
* main: (33 commits)
  feat (postgres): support for creating and restoring Snapshots (testcontainers#2199)
  fix: apply volume options only to volumes (testcontainers#2201)
  redpanda/test: add admin client call (testcontainers#2200)
  chore(deps): bump cloud.google.com/go/spanner from 1.55.0 to 1.56.0 in /modules/gcloud, cloud.google.com/go/pubsub from 1.35.0 to 1.36.1 in /modules/gcloud, cloud.google.com/go/bigquery from 1.57.1 to 1.58.0 in /modules/gcloud (testcontainers#2197)
  chore(deps): bump github.com/docker/docker from 25.0.1+incompatible to 25.0.2+incompatible (testcontainers#2196)
  fix: go doc reference broken image (testcontainers#2195)
  Add Support for WASM Transforms to Redpanda Module (testcontainers#2170)
  feat(modules.clickhouse): Add zookeeper for clickhouse clusterization (testcontainers#1995)
  redpanda: allow using SASL and TLS together (testcontainers#2140)
  chore: do not panic in testable examples (testcontainers#2193)
  fix: all mounts should contain the testcontainers labels (testcontainers#2191)
  [redpanda] sasl test for wrong mechanism (testcontainers#2048)
  fix: deprecate BindMounts correctly (testcontainers#2190)
  chore(docker_mounts): stop doing misleading logging (testcontainers#2178)
  fix: Add HTTPStrategy WithForcedIPv4LocalHost To Fix Docker Port Map (testcontainers#1775)
  chore(deps): bump github.com/docker/compose/v2 in /modules/compose (testcontainers#2162)
  feat(modules.cockroachdb) Adds cockroachdb module (testcontainers#2131)
  chore(deps): bump golang.org/x/crypto in /modules/minio (testcontainers#2161)
  chore(deps): bump golang.org/x/crypto in /modules/openldap (testcontainers#2165)
  chore(deps): bump github.com/google/uuid from 1.5.0 to 1.6.0 (testcontainers#2169)
  ...
mdelapenya added a commit to Chris-AS1/testcontainers-go that referenced this pull request Feb 14, 2024
* main:
  feat (postgres): support for creating and restoring Snapshots (testcontainers#2199)
  fix: apply volume options only to volumes (testcontainers#2201)
  redpanda/test: add admin client call (testcontainers#2200)
  chore(deps): bump cloud.google.com/go/spanner from 1.55.0 to 1.56.0 in /modules/gcloud, cloud.google.com/go/pubsub from 1.35.0 to 1.36.1 in /modules/gcloud, cloud.google.com/go/bigquery from 1.57.1 to 1.58.0 in /modules/gcloud (testcontainers#2197)
  chore(deps): bump github.com/docker/docker from 25.0.1+incompatible to 25.0.2+incompatible (testcontainers#2196)
  fix: go doc reference broken image (testcontainers#2195)
  Add Support for WASM Transforms to Redpanda Module (testcontainers#2170)
weeco pushed a commit to redpanda-data/console that referenced this pull request Feb 20, 2024
Adds integration tests. Depends on testcontainers/testcontainers-go#2170 which I've added using a replace directive to enable testing/reviewing. I will remove it as soon as I can get the upstream PR merged.
weeco pushed a commit to redpanda-data/console that referenced this pull request Feb 20, 2024
Adds integration tests. Depends on testcontainers/testcontainers-go#2170 which I've added using a replace directive to enable testing/reviewing. I will remove it as soon as I can get the upstream PR merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants