Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecate BindMounts correctly #2190

Merged
merged 1 commit into from Feb 1, 2024
Merged

fix: deprecate BindMounts correctly #2190

merged 1 commit into from Feb 1, 2024

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It brings back the BindMount type to the mounts mapping, as it was removed in https://github.com/testcontainers/testcontainers-go/pull/1907/files#diff-f8dd512f57a3d3bc890983ea0164e44d1aa69034527ccf41217f0f2807a76917L6

Why is it important?

The BindMount type needs to exist in the mapping until the type is
finally removed, otherwise the deprecation path is broken for those
using the BindMount type before the final removal.

Related issues

How to test this PR

  1. Fetch this branch
  2. Clone https://github.com/srabraham/demobindmount
  3. Update go.mod to replace the testcontainers-go dependency to use the local branch
  4. Run go mod tidy && go run main.go in the repro project.

@mdelapenya
fix: deprecate BindMounts correctly
d91d8dc 
The BindMount type needs to exist in the mapping until the type is
finally removed
@mdelapenya mdelapenya requested a review from a team as a code owner February 1, 2024 17:07
@mdelapenya mdelapenya added the bug An issue with the library label Feb 1, 2024
@mdelapenya mdelapenya self-assigned this Feb 1, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 1, 2024 •
edited

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit d91d8dc
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65bbcfbc23c3a80008670600
😎 Deploy Preview https://deploy-preview-2190--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Collaborator Author

@srabraham would you mind taking a look? Thanks!

@srabraham
Copy link
Contributor

srabraham commented Feb 1, 2024 •
edited

Verified! I modified my demo repo's go.mod locally to include

replace github.com/testcontainers/testcontainers-go => github.com/mdelapenya/testcontainers-go mdelapenya:fix-bind-mounts-deprecation

then I did a go mod tidy and a go run main.go, and it worked as expected. Thank you!

@mdelapenya mdelapenya merged commit 60cf941 into testcontainers:main Feb 1, 2024
80 checks passed
@mdelapenya mdelapenya deleted the fix-bind-mounts-deprecation branch February 1, 2024 21:55
mdelapenya added a commit to gene-redpanda/testcontainers-go that referenced this pull request Feb 2, 2024
@mdelapenya
Merge branch 'main' into feature/add-redpanda-wasm-transform
6495231 
* main:
  feat(modules.clickhouse): Add zookeeper for clickhouse clusterization (testcontainers#1995)
  redpanda: allow using SASL and TLS together (testcontainers#2140)
  chore: do not panic in testable examples (testcontainers#2193)
  fix: all mounts should contain the testcontainers labels (testcontainers#2191)
  [redpanda] sasl test for wrong mechanism (testcontainers#2048)
  fix: deprecate BindMounts correctly (testcontainers#2190)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Feb 14, 2024
@mdelapenya
Merge branch 'main' into user-defined-lifecycle-hooks
0b7c18b 
* main: (33 commits)
  feat (postgres): support for creating and restoring Snapshots (testcontainers#2199)
  fix: apply volume options only to volumes (testcontainers#2201)
  redpanda/test: add admin client call (testcontainers#2200)
  chore(deps): bump cloud.google.com/go/spanner from 1.55.0 to 1.56.0 in /modules/gcloud, cloud.google.com/go/pubsub from 1.35.0 to 1.36.1 in /modules/gcloud, cloud.google.com/go/bigquery from 1.57.1 to 1.58.0 in /modules/gcloud (testcontainers#2197)
  chore(deps): bump github.com/docker/docker from 25.0.1+incompatible to 25.0.2+incompatible (testcontainers#2196)
  fix: go doc reference broken image (testcontainers#2195)
  Add Support for WASM Transforms to Redpanda Module (testcontainers#2170)
  feat(modules.clickhouse): Add zookeeper for clickhouse clusterization (testcontainers#1995)
  redpanda: allow using SASL and TLS together (testcontainers#2140)
  chore: do not panic in testable examples (testcontainers#2193)
  fix: all mounts should contain the testcontainers labels (testcontainers#2191)
  [redpanda] sasl test for wrong mechanism (testcontainers#2048)
  fix: deprecate BindMounts correctly (testcontainers#2190)
  chore(docker_mounts): stop doing misleading logging (testcontainers#2178)
  fix: Add HTTPStrategy WithForcedIPv4LocalHost To Fix Docker Port Map (testcontainers#1775)
  chore(deps): bump github.com/docker/compose/v2 in /modules/compose (testcontainers#2162)
  feat(modules.cockroachdb) Adds cockroachdb module (testcontainers#2131)
  chore(deps): bump golang.org/x/crypto in /modules/minio (testcontainers#2161)
  chore(deps): bump golang.org/x/crypto in /modules/openldap (testcontainers#2165)
  chore(deps): bump github.com/google/uuid from 1.5.0 to 1.6.0 (testcontainers#2169)
  ...
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Feb 14, 2024
@mdelapenya
Merge branch 'main' into user-defined-lifecycle-hooks
3fa1e37 
* main: (33 commits)
  feat (postgres): support for creating and restoring Snapshots (testcontainers#2199)
  fix: apply volume options only to volumes (testcontainers#2201)
  redpanda/test: add admin client call (testcontainers#2200)
  chore(deps): bump cloud.google.com/go/spanner from 1.55.0 to 1.56.0 in /modules/gcloud, cloud.google.com/go/pubsub from 1.35.0 to 1.36.1 in /modules/gcloud, cloud.google.com/go/bigquery from 1.57.1 to 1.58.0 in /modules/gcloud (testcontainers#2197)
  chore(deps): bump github.com/docker/docker from 25.0.1+incompatible to 25.0.2+incompatible (testcontainers#2196)
  fix: go doc reference broken image (testcontainers#2195)
  Add Support for WASM Transforms to Redpanda Module (testcontainers#2170)
  feat(modules.clickhouse): Add zookeeper for clickhouse clusterization (testcontainers#1995)
  redpanda: allow using SASL and TLS together (testcontainers#2140)
  chore: do not panic in testable examples (testcontainers#2193)
  fix: all mounts should contain the testcontainers labels (testcontainers#2191)
  [redpanda] sasl test for wrong mechanism (testcontainers#2048)
  fix: deprecate BindMounts correctly (testcontainers#2190)
  chore(docker_mounts): stop doing misleading logging (testcontainers#2178)
  fix: Add HTTPStrategy WithForcedIPv4LocalHost To Fix Docker Port Map (testcontainers#1775)
  chore(deps): bump github.com/docker/compose/v2 in /modules/compose (testcontainers#2162)
  feat(modules.cockroachdb) Adds cockroachdb module (testcontainers#2131)
  chore(deps): bump golang.org/x/crypto in /modules/minio (testcontainers#2161)
  chore(deps): bump golang.org/x/crypto in /modules/openldap (testcontainers#2165)
  chore(deps): bump github.com/google/uuid from 1.5.0 to 1.6.0 (testcontainers#2169)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srabraham srabraham srabraham approved these changes

Assignees

@mdelapenya mdelapenya

Labels
bug An issue with the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: v0.27.0 breaks bind mounts
2 participants
@mdelapenya @srabraham