Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait more time in test #2211

Merged
merged 1 commit into from Feb 15, 2024
Merged

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It grows the startup timeout from 200ms to 2s (x10) in the test introduced in #2199

Why is it important?

We are seeing certain flakiness in the CI, so those 200ms could be not enough for the file to exist in the container.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner February 15, 2024 00:15
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Feb 15, 2024
@mdelapenya mdelapenya self-assigned this Feb 15, 2024
Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 43c4eca
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65cd579ff07244000801ece4
😎 Deploy Preview https://deploy-preview-2211--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya merged commit 1f628e2 into testcontainers:main Feb 15, 2024
75 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant