Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retire dependabot #2325

Merged
merged 2 commits into from Mar 7, 2024

Conversation

mdelapenya
Copy link
Collaborator

@mdelapenya mdelapenya commented Mar 5, 2024

  • chore: remove dependabot
  • chore: remove unused param

What does this PR do?

It removes dependabot from the project, delegating the update of the dependencies to the maintainers.

For that we are simplifying the existing dependabot descriptor, keeping github actions and pip dependencies in there. Finally, the code generation tool for modules has been updated to remove all dependabot code.

Why is it important?

It's creating more work than the benefit of continuously updating deps to latest. Also, does it make sense to be in the latest dependency, unless it's for security reasons?

Please see #2324 for context.

Related issues

@mdelapenya mdelapenya added the dependencies Dependencies or external services label Mar 5, 2024
@mdelapenya mdelapenya self-assigned this Mar 5, 2024
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 79f4a3e
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65e73f98850ed7000834ffcc
😎 Deploy Preview https://deploy-preview-2325--testcontainers-go.netlify.app/modules
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya marked this pull request as ready for review March 7, 2024 19:40
@mdelapenya mdelapenya requested a review from a team as a code owner March 7, 2024 19:40
@mdelapenya mdelapenya merged commit c6f1f53 into testcontainers:main Mar 7, 2024
96 checks passed
@mdelapenya mdelapenya deleted the retire-dependabot branch March 8, 2024 02:52
mdelapenya added a commit to JJCinAZ/testcontainers-go that referenced this pull request Mar 13, 2024
* main: (239 commits)
  Move the container and config tests into a test package (testcontainers#2242)
  Added error handling for context.Canceled in log reading code (testcontainers#2268)
  chore: updated docker compose version (testcontainers#2340)
  Add method for getting Weaviate's gRPC port (testcontainers#2339)
  chore: use withEnv in localstack module (testcontainers#2337)
  docs: fix wrong copy&paste (testcontainers#2338)
  fix: consul race on HTTP port (testcontainers#2336)
  chore(deps): bump mkdocs-material from 8.2.7 to 9.5.13 (testcontainers#2334)
  feat: add openfga module (testcontainers#2332)
  chore: retire dependabot (testcontainers#2325)
  chore: check that the new version is not empty (testcontainers#2331)
  chore: prepare for next minor development cycle (0.30.0)
  chore: use new version (v0.29.1) in modules and examples
  fix: incorrect version
  chore: prepare for next minor development cycle ()
  chore: use new version (v0.29.0) in modules and examples
  generic.go: GenericContainer(): clearer error message (testcontainers#2327)
  chore: confirm support for new mongo images (testcontainers#2326)
  Add k3s WithManifest option (testcontainers#1920)
  chore(deps): bump google.golang.org/grpc in /modules/qdrant (testcontainers#2281)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant