redpanda: set entrypoint to the custom entrypoint file #2347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Redpanda module has a custom entrypoint file
/entrypoint-tc.sh
that waits until the actual Redpanda broker node config file is mounted.Then proceeds to call the normal Redpanda entryfile
/entrypoint.sh
.The current implementation of the module sets the entrypoint file into the
Cmd
of theContainerRequest
.This seems to work with
Docker
, but does not work withPodman
.This results in an error when starting the container:
Since the intent is to override the entrypoint, we should be setting
Entrypoint
property as this is more appropriate.In more detail, if we inspect the Docker container:
But if we inspect the Podman container:
We can see the Entrypoint for Podman container includes the stock Redpanda
entrypoint.sh
.Why is it important?
It is more correct to override entrypoint this way.
How to test this PR
I have tested this change using Docker, and also using Podman, without changing code under test.
TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE
,TESTCONTAINERS_RYUK_CONTAINER_PRIVILEGED
, andDOCKER_HOST
env vars were set to accommodate proper running of Ryuk, and test environment. I ran into issues #2264 and #538.