Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed documentation on TESTCONTAINERS_HOST_OVERRIDE #2522

Closed
wants to merge 2 commits into from

Conversation

hanapedia
Copy link

@hanapedia hanapedia commented Apr 30, 2024

What does this PR do?

Fixed the documentation around overriding the host of the docker daemon where the container port is exposed.
It was wrongfully documented to set TESTCONTAINERS_HOST_OVERRIDE environment variable. The correct environment variable is TC_HOST.

Why is it important?

Current documentation is wrong as settingTESTCONTAINERS_HOST_OVERRIDE does not override the host of the docker daemon where the container port is exposed.

Related issues

@hanapedia hanapedia requested a review from a team as a code owner April 30, 2024 18:11
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit f8a3e82
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/663794a9ca83a9000877bc15
😎 Deploy Preview https://deploy-preview-2522--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Collaborator

mdelapenya commented May 8, 2024

Hi @hanapedia I think what we need here is to replace the usage of TC_HOST in the code with TESTCONTAINERS_HOST_OVERRIDE. That will be aligned with the other testcontainers implementations.

Wdyt?

@hanapedia
Copy link
Author

@mdelapenya
Thanks for the feedback! I agree that it will be better to replace TC_HOST with TESTCONTAINERS_HOST_OVERRIDE if it aligns with other testcontainers projects. I just noticed that TC_HOST seemed to be deprecated in other projects.
I will make a new PR on this ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TESTCONTAINERS_HOST_OVERRIDE is documented but not implemented
2 participants