Rename TC_HOST environment variable to TESTCONTAINERS_HOST_OVERRIDE #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanapedia
commented
May 8, 2024
| @@ -3,7 +3,7 @@ | |||
| _Testcontainers for Go_ supports the use of Podman (rootless or rootful) instead of Docker. | |||
|
|
|||
| In most scenarios no special setup is required in _Testcontainers for Go_. | |||
| _Testcontainers for Go_ will automatically discover the socket based on the `DOCKER_HOST` or the `TC_HOST` environment variables. | |||
| _Testcontainers for Go_ will automatically discover the socket based on the `DOCKER_HOST` environment variables. | |||
There was a problem hiding this comment.
I intentionally remove the mention on TC_HOST did not add TESTCONTAINERS_HOST_OVERRIDE here because, from what I could tell by going through the source code for socket detection, I believe TC_HOST (or TESTCONTAINERS_HOST_OVERRIDE) environment variable was not used. tc.host in .testcontainers.properties seems to be used but not TC_HOST (or TESTCONTAINERS_HOST_OVERRIDE) environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename
TC_HOSTenvironment variable toTESTCONTAINERS_HOST_OVERRIDEto align with other testcontainers projects.Why is it important?
The changes in this PR will align how to override the host of the docker daemon where the container port is exposed with other testcontainers projects and the current
testcontainers-godocumentation.In other testcontainers projects,
TESTCONTAINERS_HOST_OVERRIDEenvironment variable is used to override host of the docker daemon where the container port is exposed.testcontainers-gomentions this environment variable in the documentation but it is currently not implemented. Instead,testcontainers-gousesTC_HOST, which is the old envrionment variable used in other projects for the same purpose.Related issues
Follow-ups
The changes in this PR will deprecate
TC_HOSTenvironment variable.