fix(compose): wait.ForExit() strategy should work for finished containers #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #514 +/- ##
==========================================
+ Coverage 68.88% 68.98% +0.09%
==========================================
Files 22 22
Lines 2144 2144
==========================================
+ Hits 1477 1479 +2
+ Misses 528 526 -2
Partials 139 139
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi @Malinskiy, thanks for your contribution, I've rebased the branch with upstream and if the CI is still ✅ will merge it. And sorry for the late response 😢 |
mdelapenya
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
LGTM, thanks for this contribution!
I think you should be aware of #476, which refactors compose to be used natively in Go, instead of using a shelled version of compose. So at some point I'd suggest discussing with the original author about possible changes in that PR (I started it here, but you probably find others)
Thanks again for your time here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the #374 (comment)