Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add host param to url function for wait.ForSQL #524

Merged
merged 1 commit into from Sep 15, 2022
Merged

feat: add host param to url function for wait.ForSQL #524

merged 1 commit into from Sep 15, 2022

Conversation

frozenbonito
Copy link
Contributor

closes #490

@frozenbonito frozenbonito requested a review from a team as a code owner September 14, 2022 15:00
@mdelapenya mdelapenya self-assigned this Sep 14, 2022
@mdelapenya mdelapenya added the breaking change Causing compatibility issues. label Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022 •
edited

Codecov Report

Merging #524 (8200011) into main (f684e45) will decrease coverage by 0.12%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   69.35%   69.22%   -0.13%     
==========================================
  Files          22       22              
  Lines        2144     2148       +4     
==========================================
  Hits         1487     1487              
- Misses        521      525       +4     
  Partials      136      136
Impacted Files Coverage Δ
wait/sql.go 23.07% <16.66%> (-1.93%) ⬇️
docker.go 71.87% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mdelapenya
mdelapenya approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@mdelapenya mdelapenya left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your contribution @frozenbonito, there is no docs page at this moment for wait.ForSQL, although we are working on that. I'll make sure this behavior appears there

@mdelapenya mdelapenya merged commit 769d576 into testcontainers:main Sep 15, 2022
@frozenbonito frozenbonito deleted the add-host-param-to-url-function-for-waitforsql branch September 15, 2022 14:12
@frozenbonito
Copy link
Contributor Author

Thank you for merging!

This was referenced Oct 3, 2022
Closed
Closed
@mdelapenya mdelapenya mentioned this pull request Oct 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels
breaking change Causing compatibility issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why doesn't url function for wait.ForSQL() have a host parameter?
2 participants
@frozenbonito @mdelapenya