Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retire old versions of Go #530

Merged
merged 3 commits into from Sep 16, 2022
Merged

chore: retire old versions of Go #530

merged 3 commits into from Sep 16, 2022

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It removes go1.16 and go1.17 from the CI, as they are not supported any more

Why is it important?

Let's keep only the supported versions (last two minors)

Related issues

Follow-ups

We could automate the bump of the Go versions that are supported at CI time, see #529 comment

Let's keep only the supported versions (last two minors)
@mdelapenya mdelapenya requested a review from a team as a code owner September 16, 2022 08:40
@mdelapenya mdelapenya added dependencies Dependencies or external services chore Changes that do not impact the existing functionality labels Sep 16, 2022
@mdelapenya mdelapenya self-assigned this Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #530 (2d6fa23) into main (280cf69) will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   68.99%   69.22%   +0.23%     
==========================================
  Files          22       22              
  Lines        2148     2148              
==========================================
+ Hits         1482     1487       +5     
+ Misses        528      525       -3     
+ Partials      138      136       -2     
Impacted Files Coverage Δ
docker.go 71.87% <0.00%> (+0.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mdelapenya mdelapenya merged commit 1486bcc into main Sep 16, 2022
@mdelapenya mdelapenya deleted the retire-go-1.17 branch November 15, 2022 12:18
mdelapenya referenced this pull request in mdelapenya/testcontainers-go Dec 21, 2022
* main:
  Add system requirements parent docs page for podman and colima (#562)
  Support for cap-add/cap-drop (#555)
  fix container NetworkMode usage (#560)
  chore: use hashed versions of test-summary action (#556)
  chore: use container.State() function in tests (#543)
  Log docker server info (#548)
  docs: add docs regarding Colima usage (#547)
  chore: add emoji to breaking changes in release drafter (#542)
  chore: add CONTRIBUTING file (#539)
  issue #537 Rename the wait/multi.go file to wait/all.go (#541)
  docs: add a basic layout for wait strategies in docs (#536)
  docs: improve consistency and fix typos (#534)
  chore: do not skip test (#528)
  chore: include test flakiness in the release drafter (#535)
  chore: retire old versions of Go (#530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: retire Go 1.17 from CI
2 participants