Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #537 Rename the wait/multi.go file to wait/all.go #541

Merged
merged 1 commit into from Oct 1, 2022

Conversation

skofli
Copy link
Contributor

@skofli skofli commented Oct 1, 2022

Closes #537

@skofli skofli requested a review from a team as a code owner October 1, 2022 08:39
@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Merging #541 (dd81fd3) into main (7d0afb7) will decrease coverage by 0.27%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   68.88%   68.61%   -0.28%     
==========================================
  Files          22       22              
  Lines        2144     2154      +10     
==========================================
+ Hits         1477     1478       +1     
- Misses        528      537       +9     
  Partials      139      139              
Impacted Files Coverage Δ
testing.go 0.00% <ø> (ø)
wait/all.go 0.00% <ø> (ø)
wait/sql.go 22.22% <11.11%> (-2.78%) ⬇️
wait/host_port.go 47.47% <40.00%> (-0.95%) ⬇️
compose.go 74.04% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mdelapenya mdelapenya self-assigned this Oct 1, 2022
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Oct 1, 2022
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!! LGTM

@mdelapenya mdelapenya merged commit bdb1026 into testcontainers:main Oct 1, 2022
mdelapenya referenced this pull request in mdelapenya/testcontainers-go Dec 21, 2022
* main:
  Add system requirements parent docs page for podman and colima (#562)
  Support for cap-add/cap-drop (#555)
  fix container NetworkMode usage (#560)
  chore: use hashed versions of test-summary action (#556)
  chore: use container.State() function in tests (#543)
  Log docker server info (#548)
  docs: add docs regarding Colima usage (#547)
  chore: add emoji to breaking changes in release drafter (#542)
  chore: add CONTRIBUTING file (#539)
  issue #537 Rename the wait/multi.go file to wait/all.go (#541)
  docs: add a basic layout for wait strategies in docs (#536)
  docs: improve consistency and fix typos (#534)
  chore: do not skip test (#528)
  chore: include test flakiness in the release drafter (#535)
  chore: retire old versions of Go (#530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the wait/multi.go file to wait/all.go:
2 participants