Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add emoji to breaking changes in release drafter #542

Merged
merged 1 commit into from Oct 3, 2022

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It adds the warning emoji to the Breaking changes section in the Release Drafter's configuration file

Why is it important?

Consistency with the rest of the sections (emoji + title) and with the Java changelog, which uses the same emoji

@mdelapenya mdelapenya requested a review from a team as a code owner October 3, 2022 08:11
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Oct 3, 2022
@mdelapenya mdelapenya self-assigned this Oct 3, 2022
@mdelapenya mdelapenya requested a review from a team October 3, 2022 08:11
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #542 (709c6c8) into main (bdb1026) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
+ Coverage   68.57%   68.61%   +0.04%     
==========================================
  Files          22       22              
  Lines        2154     2154              
==========================================
+ Hits         1477     1478       +1     
  Misses        537      537              
+ Partials      140      139       -1     
Impacted Files Coverage Δ
docker.go 70.82% <0.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mdelapenya mdelapenya merged commit 4c79569 into testcontainers:main Oct 3, 2022
@mdelapenya mdelapenya deleted the breaking-changes-icon branch October 3, 2022 16:09
mdelapenya referenced this pull request in mdelapenya/testcontainers-go Dec 21, 2022
* main:
  Add system requirements parent docs page for podman and colima (#562)
  Support for cap-add/cap-drop (#555)
  fix container NetworkMode usage (#560)
  chore: use hashed versions of test-summary action (#556)
  chore: use container.State() function in tests (#543)
  Log docker server info (#548)
  docs: add docs regarding Colima usage (#547)
  chore: add emoji to breaking changes in release drafter (#542)
  chore: add CONTRIBUTING file (#539)
  issue #537 Rename the wait/multi.go file to wait/all.go (#541)
  docs: add a basic layout for wait strategies in docs (#536)
  docs: improve consistency and fix typos (#534)
  chore: do not skip test (#528)
  chore: include test flakiness in the release drafter (#535)
  chore: retire old versions of Go (#530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants