chore: use hashed versions of test-summary action #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
added
dependencies
Codecov Report
@@ Coverage Diff @@
## main #556 +/- ##
==========================================
+ Coverage 68.83% 69.01% +0.18%
==========================================
Files 22 22
Lines 2172 2172
==========================================
+ Hits 1495 1499 +4
+ Misses 537 535 -2
+ Partials 140 138 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Can we please limit review requests to the language-specific team? I get notified by every request for @testcontainers/oss-team but I only maintain the Rust impl. |
Makes sense, and sorry for noise. I was not aware that the oss-team included other projects apart from java, go and .NET. Will change patterns ASAP |
This reverts commit 4d947b2.
This was referenced Oct 18, 2022
Merged
mdelapenya
referenced
this pull request
in mdelapenya/testcontainers-go
Dec 21, 2022
* main: Add system requirements parent docs page for podman and colima (#562) Support for cap-add/cap-drop (#555) fix container NetworkMode usage (#560) chore: use hashed versions of test-summary action (#556) chore: use container.State() function in tests (#543) Log docker server info (#548) docs: add docs regarding Colima usage (#547) chore: add emoji to breaking changes in release drafter (#542) chore: add CONTRIBUTING file (#539) issue #537 Rename the wait/multi.go file to wait/all.go (#541) docs: add a basic layout for wait strategies in docs (#536) docs: improve consistency and fix typos (#534) chore: do not skip test (#528) chore: include test flakiness in the release drafter (#535) chore: retire old versions of Go (#530)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It uses the commit of the v1 tag in the
test-summaryaction, pinning it to thev1version (see https://github.com/test-summary/action/releases/tag/v1.0)I also noticed that junit test reports were not generated (added here d0116e4 but removed during a merge, probably here 897803f). Therefore I'm adding the
--junitfileflag togotestsum, ignoring the test reports from git, and finally runninggo mod tidyin the e2e module to sync the module dependencies.Why is it important?
Security concerns about using dynamic version of GH actions, and recover the summary action