fix: expose default exposed ports if the NetworkMode is not container #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker cannot do container network mode with exposed ports. in order to make it work, only calculate the default exposed ports if the NetworkMode is NOT container.
|
This PR is related to #468, as it introduced a change in which all ports will be exposed if no exposed ports were defined at the container request |
kiview
approved these changes
Oct 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #560 +/- ##
==========================================
+ Coverage 69.01% 69.24% +0.23%
==========================================
Files 22 22
Lines 2172 2172
==========================================
+ Hits 1499 1504 +5
+ Misses 535 532 -3
+ Partials 138 136 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mdelapenya
approved these changes
Oct 7, 2022
mdelapenya
changed the title
mdelapenya
referenced
this pull request
in mdelapenya/testcontainers-go
Dec 21, 2022
* main: Add system requirements parent docs page for podman and colima (#562) Support for cap-add/cap-drop (#555) fix container NetworkMode usage (#560) chore: use hashed versions of test-summary action (#556) chore: use container.State() function in tests (#543) Log docker server info (#548) docs: add docs regarding Colima usage (#547) chore: add emoji to breaking changes in release drafter (#542) chore: add CONTRIBUTING file (#539) issue #537 Rename the wait/multi.go file to wait/all.go (#541) docs: add a basic layout for wait strategies in docs (#536) docs: improve consistency and fix typos (#534) chore: do not skip test (#528) chore: include test flakiness in the release drafter (#535) chore: retire old versions of Go (#530)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker cannot do container network mode with exposed ports.
in order to make it work, only calculate the default exposed
ports if the NetworkMode is NOT container.