Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system requirements parent docs page for podman and colima #562

Merged
merged 2 commits into from Oct 10, 2022

Conversation

gauravgahlot
Copy link
Contributor

Closes - #554

Screenshot 2022-10-08 at 10 21 50 PM

Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
@gauravgahlot gauravgahlot requested a review from a team as a code owner October 8, 2022 16:54
@gauravgahlot
Copy link
Contributor Author

@mdelapenya I'm a bit unsure if this is the only required change. Please take a look and let me know.

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #562 (5706495) into main (917b257) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   69.04%   69.04%           
=======================================
  Files          22       22           
  Lines        2174     2174           
=======================================
  Hits         1501     1501           
  Misses        535      535           
  Partials      138      138           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mkdocs.yml Show resolved Hide resolved
@mdelapenya mdelapenya self-assigned this Oct 9, 2022
@mdelapenya mdelapenya added documentation Docs, docs, docs. hacktoberfest Pull Requests accepted for Hacktoberfest. labels Oct 9, 2022
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contributions!

@mdelapenya mdelapenya merged commit d118f89 into testcontainers:main Oct 10, 2022
@gauravgahlot gauravgahlot deleted the docs branch October 10, 2022 06:01
mdelapenya referenced this pull request in mdelapenya/testcontainers-go Dec 21, 2022
* main:
  Add system requirements parent docs page for podman and colima (#562)
  Support for cap-add/cap-drop (#555)
  fix container NetworkMode usage (#560)
  chore: use hashed versions of test-summary action (#556)
  chore: use container.State() function in tests (#543)
  Log docker server info (#548)
  docs: add docs regarding Colima usage (#547)
  chore: add emoji to breaking changes in release drafter (#542)
  chore: add CONTRIBUTING file (#539)
  issue #537 Rename the wait/multi.go file to wait/all.go (#541)
  docs: add a basic layout for wait strategies in docs (#536)
  docs: improve consistency and fix typos (#534)
  chore: do not skip test (#528)
  chore: include test flakiness in the release drafter (#535)
  chore: retire old versions of Go (#530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs. hacktoberfest Pull Requests accepted for Hacktoberfest.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants