Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better error message in tests #577

Merged
merged 2 commits into from Oct 22, 2022

Conversation

mdelapenya
Copy link
Collaborator

@mdelapenya mdelapenya commented Oct 21, 2022

What does this PR do?

It removes the error messages to be verified when copying directories into non-existing paths in a container, using a bool variable to assert for the error

Why is it important?

Fix the build

Related issues

@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #577 (6457d94) into main (9bee089) will decrease coverage by 19.10%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #577       +/-   ##
===========================================
- Coverage   34.50%   15.40%   -19.11%     
===========================================
  Files          13       13               
  Lines        1759     1759               
===========================================
- Hits          607      271      -336     
- Misses       1056     1442      +386     
+ Partials       96       46       -50     
Impacted Files Coverage Δ
reaper.go 3.50% <0.00%> (-71.93%) ⬇️
mounts.go 0.00% <0.00%> (-50.00%) ⬇️
docker_mounts.go 9.75% <0.00%> (-36.59%) ⬇️
docker.go 20.33% <0.00%> (-20.94%) ⬇️
container.go 40.96% <0.00%> (-18.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mdelapenya mdelapenya merged commit 6b8d699 into testcontainers:main Oct 22, 2022
@mdelapenya mdelapenya deleted the more-consistency-in-tests branch October 22, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant