Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codecov #579

Closed
mdelapenya opened this issue Oct 22, 2022 · 3 comments · Fixed by #584
Closed

Remove codecov #579

mdelapenya opened this issue Oct 22, 2022 · 3 comments · Fixed by #584
Labels
dependencies Dependencies or external services hacktoberfest Pull Requests accepted for Hacktoberfest.

Comments

@mdelapenya
Copy link
Collaborator

mdelapenya commented Oct 22, 2022

Proposal

There a lot of PRs failing codecov's GH check even though the modified files are i.e. only docs

Examples:

We are not paying attention at the code coverage at this moment, so I recommend removing it until a) there is less or even zero noise in the PRs; and b)we look at the code coverage to identify not covered parts of the codebase.

@mdelapenya mdelapenya added dependencies Dependencies or external services hacktoberfest Pull Requests accepted for Hacktoberfest. labels Oct 22, 2022
@misantron
Copy link
Contributor

Can I take this issue?

@misantron
Copy link
Contributor

Is it enough to comment the job inside CI pipeline or you want completely remove it?

@kiview
Copy link
Member

kiview commented Oct 24, 2022

@misantron It should be removed, no need to leave it in commented out (it can always be looked up from Git history when necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies or external services hacktoberfest Pull Requests accepted for Hacktoberfest.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants