New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Auth config for build images #602
feat: Auth config for build images #602
Conversation
…and documentation accordingly
@paulozenida I saw the PR is failing the testcontainers-go/docker_test.go Line 2566 in dd2248a
testresources . At the moment you added the registry dirs, that test fails, and I think it should be fixed in this PR.
I'd say that simply checking the current srcFile is not a directory, and then read it would be enough. Could you include it in this PR? Thanks! |
Sure. I've just included the suggested change. |
To avoid causing you more trouble in the pingpong review on failed tests, I added a commit with the same fix in another test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @paulozenida in this PR!
I'm updating the branch with current main. Once the CI passes, I'll merge it 🚀
BTW; the project is missing the same mechanism for pulling images from private registries in other places. As you already contributed this part for the FromDockerfile part, I wonder if you would be interested in contributing the others, such as the Docker Compose code. I can be of any help assisting you identifying where to add it. Please let me know if you'd like to participate.
Thank @mdelapenya. I'm not sure I'll be able to do that right now but if you open an issue explaining the details, I might try to get to it next week or try to find someone in my organisation/team that can try to do so. |
This PR allows for the feature reported in the following issue: #601