Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: remove mysql and redis dependencies from existing tests #661

Closed
mdelapenya opened this issue Dec 5, 2022 · 2 comments
Closed
Labels
enhancement New feature or request good first issue Want to contribute to testcontainers? Start from here

Comments

@mdelapenya
Copy link
Collaborator

mdelapenya commented Dec 5, 2022

Proposal

I noticed that the docker_test.go file is consuming both mysql and redis/v8 dependencies.

We should avoid consuming service dependencies in the main module, and instead move them to an example module (see examples dir).

In the case of Redis, we merged a PR (#602) that is using a Dockerfile to test building images from a Dockerfile consuming a base Redis image living in a private registry. This is causing the import of redis client, as the test verifies that Redis is accesible from the test.

IMO the test should be simpler and should not use redis but a simple Nginx service and check that the default HTTP port is accessible, to name a straightly simple verification.

@mdelapenya mdelapenya added good first issue Want to contribute to testcontainers? Start from here enhancement New feature or request labels Dec 5, 2022
@mdelapenya
Copy link
Collaborator Author

We probably could close #659 after this is implemented

@mdelapenya
Copy link
Collaborator Author

Closing as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Want to contribute to testcontainers? Start from here
Projects
None yet
Development

No branches or pull requests

1 participant