Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update code snippet for Docker Auth #940

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

mdelapenya
Copy link
Collaborator

  • docs: fix snippet for containerRequest and private registries
  • docs: use codeinclude

What does this PR do?

It updates the code snippet used in the Docker Auth section of the docs, which was wrong.

At the same time, it uses a codeinclude snippet.

Why is it important?

Fix the code snippet, ensuring it comes from a real code block, instead of being a plain text that could be easily outdated.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner March 14, 2023 07:01
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Mar 14, 2023
@mdelapenya mdelapenya self-assigned this Mar 14, 2023
@netlify
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit a66115c
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64101bd66bcbf20008dd894f
😎 Deploy Preview https://deploy-preview-940--testcontainers-go.netlify.app/features/docker_auth
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mdelapenya mdelapenya changed the title docs: fix code snippet for Docker Auth fix: update code snippet for Docker Auth Mar 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya mdelapenya merged commit 1c453df into testcontainers:main Mar 14, 2023
@mdelapenya mdelapenya deleted the fix-docs branch March 21, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant