Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use testdata as a Go idiom #983

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

mdelapenya
Copy link
Collaborator

  • chore: rename testresources to testdata
  • chore: move tesresources to testdata

What does this PR do?

It replaces all occurrences of testresources to testdata, also renaming all directories.

Why is it important?

From https://dave.cheney.net/2016/05/10/test-fixtures-in-go and https://pkg.go.dev/cmd/go#hdr-Description_of_package_lists:

The go tool will ignore a directory named "testdata", making it available to hold ancillary data needed by the tests.

@mdelapenya mdelapenya requested a review from a team as a code owner March 24, 2023 11:56
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Mar 24, 2023
@mdelapenya mdelapenya self-assigned this Mar 24, 2023
@netlify
Copy link

netlify bot commented Mar 24, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 6b5e3dc
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/641d941881a84e0008775413
😎 Deploy Preview https://deploy-preview-983--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
17.7% 17.7% Duplication

@mdelapenya mdelapenya merged commit 04be590 into testcontainers:main Mar 24, 2023
@mdelapenya mdelapenya deleted the testdata-convention branch March 24, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant