Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: simplify MySQL code snippet in docs #984

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It reduces the scope of the code snippet used when demonstrating how to start a MySQL container.

Why is it important?

Simplify the docs experience

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner March 24, 2023 16:31
@netlify
Copy link

netlify bot commented Mar 24, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 67e33cc
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/641dd081c2b00e00085e60e0
😎 Deploy Preview https://deploy-preview-984--testcontainers-go.netlify.app/modules/mysql
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mdelapenya mdelapenya self-assigned this Mar 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya mdelapenya merged commit 91bb0a8 into testcontainers:main Mar 24, 2023
@mdelapenya mdelapenya deleted the fix-mysql-snippet branch March 27, 2023 05:59
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants