Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder docs language links #985

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

leocross
Copy link
Contributor

@leocross leocross commented Mar 27, 2023

What is this PR doing?

It's reordering the supported langs in the docs site, to have NodeJS before Python.

Why is it important?

Consistency in the order of the languages

@leocross leocross requested a review from a team as a code owner March 27, 2023 09:06
@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 7555d0c
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64215c969c10a600083c3774
😎 Deploy Preview https://deploy-preview-985--testcontainers-go.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mdelapenya mdelapenya self-assigned this Mar 27, 2023
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @leocross

I've updated the description of the PR to match the intention of this PR, as we consider a best practice to share context to eventual readers about what this PR does and why it's needed.

@kiview kiview merged commit 1429181 into testcontainers:main Mar 27, 2023
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants