-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Redis module #993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
added
the
feature
New functionality or new behaviors on the existing one
label
Mar 27, 2023
mdelapenya
requested review from
cristianrgreco,
eddumelendez,
HofmeisterAn and
kiview
March 27, 2023 16:12
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
* main: chore: skip CI builds when updating the docs (testcontainers#996) chore: render logos from the base location (testcontainers#995) chore: include how to install the module in the generated docs (testcontainers#991)
* main: feat: Auto detect the use of Podman from DOCKER_HOST (testcontainers#982) chore(deps): bump github.com/opencontainers/runc from 1.1.3 to 1.1.5 (testcontainers#1017) Revert "chore: render logos from the base location (testcontainers#995)" (testcontainers#998)
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Apr 3, 2023
* chore: rename redis module * chore: move redis example to modules * chore: move redis in dependabot config * chore: move redis in mkdocs.yml file * chore: move redis docs * chore: rename GH workflow for redis * chore: expose StartContainer function * chore: export redis container * chore: extract a function for the connection string * chore: use require.NoError * docs: basic documentation for Redis module * feat: add WithConfigFile option * fix: link to redis module in quickstart * feat: add WithImage option * feat: support for snapshotting https://redis.io/docs/management/persistence/#snapshotting * chore: simplify processing redis-server args * feat: support for log level * docs: module reference * chore: support for redis variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It migrates the existing Redis example module to a Go module, including what's described in the docs, which are rendered at:
Why is it important?
Continue adding modules