chore: render logos from the base location #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@leocross could you take a look? 🙏 |
|
Render URL generates the right logos. I'm merging this. |
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Mar 28, 2023
* main: chore: skip CI builds when updating the docs (testcontainers#996) chore: render logos from the base location (testcontainers#995) chore: include how to install the module in the generated docs (testcontainers#991)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Mar 28, 2023
This reverts commit b89457c.
mdelapenya
added a commit
that referenced
this pull request
Mar 28, 2023
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Mar 30, 2023
* main: feat: Auto detect the use of Podman from DOCKER_HOST (testcontainers#982) chore(deps): bump github.com/opencontainers/runc from 1.1.3 to 1.1.5 (testcontainers#1017) Revert "chore: render logos from the base location (testcontainers#995)" (testcontainers#998)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It removes the trailing slash from the SRC attribute of the social links in the website.
Why is it important?
They do not get rendered when in a multi-deployment scenario (main, v0.19.0, v0.18.0, etc)