Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: render logos from the base location (#995)" #998

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

This reverts commit b89457c.

Why is it important?

For some reason, Netlify renders the icons properly in the preview URL, but does not (404 NotFound) for the production URL.

Related issues

@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Mar 28, 2023
@mdelapenya mdelapenya requested a review from a team as a code owner March 28, 2023 14:35
@mdelapenya mdelapenya self-assigned this Mar 28, 2023
@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 7cc2710
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6422fb1b243f4b00081442b4
😎 Deploy Preview https://deploy-preview-998--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya mdelapenya merged commit c96f329 into testcontainers:main Mar 28, 2023
@mdelapenya mdelapenya deleted the revert-fix-icons branch March 28, 2023 14:49
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Mar 30, 2023
* main:
  feat: Auto detect the use of Podman from DOCKER_HOST (testcontainers#982)
  chore(deps): bump github.com/opencontainers/runc from 1.1.3 to 1.1.5 (testcontainers#1017)
  Revert "chore: render logos from the base location (testcontainers#995)" (testcontainers#998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant