Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show port mappings in HttpWaitStrategy #2341

Merged
merged 5 commits into from Feb 6, 2021

Conversation

aguibert
Copy link
Contributor

Currently if an HttpWaitStrategy is used, we see an INFO level message like this:

Waiting for 30 seconds for URL: http://localhost:32123/myapp

(Where port 32123 is a randomly assigned mapped port)

It would be helpful if this log message also showed the original port number as well so we knew what port we were effectively waiting on like this:

Waiting for 30 seconds for URL: http://localhost:32123/myapp (where 32123-->8080)

@bsideup bsideup added this to the next milestone Mar 13, 2020
@bsideup bsideup removed this from the next milestone Apr 11, 2020
@stale
Copy link

stale bot commented Jul 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Jul 11, 2020
@rnorth
Copy link
Member

rnorth commented Jul 13, 2020

I'll pick this up.

@stale stale bot removed the stale label Jul 13, 2020
@rnorth rnorth self-assigned this Jul 13, 2020
@rnorth rnorth requested a review from bsideup July 17, 2020 11:04
@stale
Copy link

stale bot commented Jan 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants