Add a getter for Toxiproxy exposed port

[lutovich]

Hello!
I used Toxiproxy container to simulate a connection cut between two different Docker containers. It was a bit hard to determine what exposed port of the proxy corresponds to the exposed port of the target container. The code I ended up with did toxiproxy.getExposedPorts().get(1) which is not very intuitive because toxiproxy.getExposedPorts().get(0) is the proxy control port. Thus this PR. Hope it makes sense :)

Before this change, there only existed a getter for the mapped port which is useful for accessing the container from the host. A new getter can be useful when a Toxiproxy is setup between two different Docker containers to simulate network instabilities.

[rnorth]

This is a good idea, but I just want to have a think about naming - I think that getExposedProxyPort() could be improved upon. It definitely deserves some inline Javadocs and a general documentation update to explain what this is for and when to use it 😄

[lutovich]

Hi @rnorth, I agree, the name could be improved. What do you think about getDockerProxyPort or getContainerProxyPort?

[bsideup]

@rnorth soft ping :)

[rnorth]

Sorry - naming this is hard! I think personally I'd prefer getOriginalProxyPort or getDirectProxyPort. We should also have really solid documentation for when you should and shouldn't use this, both in the form of Javadocs and in the published markdown docs.

I think we should probably skip this for today's release - sorry that my delay in getting back slowed things down.

[lutovich]

Thanks, getOriginalProxyPort sounds good to me. I'll change the PR and add docs this week.

[lutovich]

Hi @rnorth, this PR is now updated:

• changed getter name from getExposedProxyPort to getOriginalProxyPort
• added Javadocs and markdown docs for Toxyproxy port-related methods
• attempted to fix flaky Toxiproxy tests by increasing the default Jedis timeout

Please re-review, thanks in advance :)

[rnorth]

Thanks @lutovich this is great. I just have a couple of tiny tweaks to suggest, then I think we're good to go 🙂

[lutovich]

@rnorth thanks a lot! I committed all suggestions and squashed them into one commit

[rnorth]

Looks great - thanks for the contribution @lutovich!