Support HTTP headers on HttpWaitStrategy #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiview
requested changes
Apr 10, 2020
core/src/test/java/org/testcontainers/junit/wait/strategy/AbstractWaitStrategyTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/testcontainers/junit/wait/strategy/HttpWaitStrategyTest.java
Show resolved
Hide resolved
renatomefi
force-pushed
the
feature/http-wait-strategy-headers-support
branch
from
72af46d
to
f7f5af2
Compare
|
Build failure - I'll merge from master to ensure that we're using the latest, stable (😄) master build as a basis. |
This enables webservers that depend on headers for healthchecks to be able to correctly be queried by the HttpWaitStrategy.
renatomefi
force-pushed
the
feature/http-wait-strategy-headers-support
branch
from
32ef287
to
445c3dd
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
I think it's ready to merge? |
rnorth
approved these changes
Sep 2, 2020
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables webservers that depend on headers for healthchecks to be able to correctly be queried by the HttpWaitStrategy.
As there are no unit tests for the HttpWaitStrategy I'm using the container logs as confirmation of the correct HTTP call execution.