Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Compose: Verify that all services that have a wait condition defined also have a corresponding service instance #2637

Merged
merged 1 commit into from
May 2, 2020

Conversation

jannis-baratheon
Copy link
Contributor

@jannis-baratheon jannis-baratheon commented Apr 29, 2020

Closes #2600

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @jannis-baratheon

@rnorth rnorth changed the title #2600 Verifying if all services that have a wait condition defined also have a corresponding service instance Docker Compose: Verify that all services that have a wait condition defined also have a corresponding service instance May 2, 2020
@rnorth rnorth merged commit 2bb9613 into testcontainers:master May 2, 2020
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misspelled service name in DockerComposeContainer#waitingFor is hard to debug
2 participants