Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make neo4j module support Gradle caching #2649

Merged
merged 1 commit into from
May 5, 2020
Merged

Make neo4j module support Gradle caching #2649

merged 1 commit into from
May 5, 2020

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented May 2, 2020

No description provided.

@rnorth rnorth requested review from bsideup and kiview as code owners May 2, 2020 11:22
@kiview
Copy link
Member

kiview commented May 4, 2020 •
edited

From Gradle docs:

Some tasks, like Copy or Jar, usually do not make sense to make cacheable because Gradle is only copying files from one location to another.

But we need the cache, since else we can't cache the test?

@rnorth
Copy link
Member Author

rnorth commented May 4, 2020

Yeah, I read that as well and came to the conclusion that this is a case where it makes sense to break the rules.

@rnorth rnorth merged commit 8fd4c20 into master May 5, 2020
@rnorth rnorth deleted the neo4j-build-caching branch May 5, 2020 19:58
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
@rnorth @quincy
Make neo4j module support Gradle caching (testcontainers#2649)
b8dc1f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

@bsideup bsideup Awaiting requested review from bsideup

Assignees
No one assigned
Labels
type/test-improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnorth @kiview