Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump HikariCP from 3.4.3 to 3.4.4 in /modules/spock #2678

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps HikariCP from 3.4.3 to 3.4.4.

Changelog

Sourced from HikariCP's changelog.

HikariCP Changes

Changes kn 3.4.4

  • Build HikariCP as a JEP 238 Multi-Release jar for increased compatability with Java 11 and future modularized Java versions.

Changes in 3.4.3

  • Fixed 1534 check resultSet.getStatement() for null in ProxyDatabaseMetaData.

  • Add additional debug logging around connection add.

  • Add ThreadLocal removal attempt when bag item is removed.

Changes in 3.4.2

  • fixed 1528 regression caused by pull request 1159 whereby fail-fast logic would exit upon all errors even if it was configured to continue trying.

Changes in 3.4.1

  • fix regression caused by 1337, which broke the ability to pass the isolation level by integer value (string) instead of isolation level name.

Changes in 3.4.0

  • merged 1265 alternative Prometheus metrics Histogram instead of locking Summary (which is purportedly quite lock-heavy.

  • merged 1337 support accepting TRANSACTION_SQL_SERVER_SNAPSHOT_ISOLATION_LEVEL string for isolation level.

  • merged 1331 user contribution: major refactor of metrics handling, hopefully without any breakage.

  • add proxy class for DatabaseMetaData to intercept DatabaseMetaData.getConnection() call which was leaking the raw database Connection object.

Changes in 3.3.1

  • fixed 1287 set core pool size before max pool size

  • fixed 1308 treat a SQLTimeoutException as an evictable offense

  • do not default maxPoolSize to minIdle when only minIdle is specified

  • do not log warning about idleTimeout unless minimumIdle is less than maxPoolSize (because otherwise it does not apply)

Changes in 3.3.0

... (truncated)
Commits
  • 6ee9c75 [maven-release-plugin] prepare release HikariCP-3.4.4
  • 1d05b0e Added missing dependencies (#1577)
  • 2cb6381 Remove java11 artifact classifier
  • f6fd47b Force inclusion of META-INF/versions directory in jar.
  • d9ee5fa Renamed Java9 artifact to Java11.
  • aaf4d3a Added module-info.java for Java9
  • 0dbba4b Update README.md
  • 1e35af8 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label May 8, 2020
@dependabot-preview
Copy link
Contributor Author

Dependabot tried to automerge this PR, but received the following error from GitHub:

Waiting on code owner review from bsideup, kiview, and/or rnorth.

@rnorth rnorth merged commit 05da884 into master May 8, 2020
@rnorth rnorth deleted the dependabot/gradle/modules/spock/com.zaxxer-HikariCP-3.4.4 branch May 8, 2020 07:41
@rnorth
Copy link
Member

rnorth commented May 8, 2020

Reverting due to brettwooldridge/HikariCP#1578

@rnorth
Copy link
Member

rnorth commented May 8, 2020

I am mystified as to how the tests passed before merge but failed after 🤔

quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant